[FE] fix: 꿀조합 이름, 닉네임 글자수 제한 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Sep 14, 2023
Comment on lines
+40
to
+48
| const MemberModifyInputContainer = styled.div` | ||
| position: relative; | ||
| `; | ||
|
|
||
| const NicknameStatusText = styled(Text)` | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| `; |
There was a problem hiding this comment.
flex box 를 쓸 수도 있을 것 같은데 왜 position으로 했나요?
There was a problem hiding this comment.
title을 따로 두고 싶었습니다!
container -> div -> h2보다 container -> h2 느낌??
hae-on
approved these changes
Sep 14, 2023
| 닉네임 | ||
| </Heading> | ||
| <NicknameStatusText color={theme.textColors.info} tabIndex={0}> | ||
| {nickname.length} / {MAX_LENGTH} |
| <Heading as="h2" size="xl" tabIndex={0}> | ||
| 꿀조합 이름 | ||
| <RequiredMark aria-label="필수 작성">*</RequiredMark> | ||
| </Heading> | ||
| <RecipeNameStatusText color={theme.textColors.info} tabIndex={0}> | ||
| {recipeName.length} / {MAX_LENGTH} |
xodms0309
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
x
⏰ 일정