-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] Product 엔티티에 reviewCount 필드 추가 #616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70825
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉 고생하셨어요 👍👍
70825
approved these changes
Sep 14, 2023
wugawuga
reviewed
Sep 14, 2023
wugawuga
approved these changes
Sep 14, 2023
Go-Jaecheol
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~~~~~~~~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
오늘 아침에 다같이 논의했던대로
Product 엔티티에 reviewCount 필드 추가 (반정규화) 진행했습니다.
📢 논의하고 싶은 내용
🎸 기타
사용자가 서비스 접속시 가장 많이 접근하는 페이지는 홈과 상품 목록 페이지이다.
그 중 상품 목록 페이지의 경우 상품에 대한 정보와 리뷰의 개수를 함께 보여준다.
(기존)
상품 목록 조회시 상품과 리뷰를 JOIN * 10번
(반정규화시)
상품 목록 조회시 상품 단독 조회 * 10번
리뷰를 작성하는 것보다 (reviewCount++) 상품 목록 조회(join)가 더 자주 발생할 것이라 판단하여 반정규화를 진행한다.
⏰ 일정