Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] refactor: image url만 받게 수정 #568

Merged
merged 7 commits into from
Sep 8, 2023
Merged

[BE] refactor: image url만 받게 수정 #568

merged 7 commits into from
Sep 8, 2023

Conversation

wugawuga
Copy link
Collaborator

@wugawuga wugawuga commented Sep 4, 2023 •
edited
Loading

Issue

✨ 구현한 기능

  • 원래 이미지 업로드 하던 거 걷어냈습니다.

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 0.5

@wugawuga wugawuga self-assigned this Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

Unit Test Results

225 tests   225 ✔️  16s ⏱️
112 suites      0 💤
112 files        0 ❌

Results for commit e4d0545.

♻️ This comment has been updated with latest results.

70825
70825 reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.gradle에 있는 이미지 관련 의존성들 전부 삭제해도 문제 없어보여요
레벨3 초반에 적용하려고 했던 restdocs + swagger도 다시 생각해볼 수 있을지도..??
머지되면 저도 AOP 로깅 적용하겠습니다~
우가 최고 👍👍

backend/src/main/java/com/funeat/recipe/application/RecipeService.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/recipe/application/RecipeService.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/acceptance/member/MemberSteps.java Outdated Show resolved Hide resolved
Go-Jaecheol
Go-Jaecheol approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

많이 귀찮은 작업이었을텐데 고생하셨어요~~ 👍

hanueleee
hanueleee requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 저장 로직 추출 고생하셨습니다아..🤣

backend/src/main/java/com/funeat/member/dto/MemberRequest.java Show resolved Hide resolved
backend/src/main/java/com/funeat/member/application/MemberService.java Outdated Show resolved Hide resolved
@wugawuga wugawuga closed this Sep 6, 2023
@wugawuga wugawuga reopened this Sep 8, 2023
@wugawuga wugawuga merged commit 6c82c7b into develop Sep 8, 2023
3 checks passed
@wugawuga wugawuga deleted the refactor/issue-567 branch September 8, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanueleee hanueleee hanueleee approved these changes

@70825 70825 70825 approved these changes

@Go-Jaecheol Go-Jaecheol Awaiting requested review from Go-Jaecheol

Assignees

@wugawuga wugawuga

Labels
🔒 BE 🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] review dto 패키지 이동 [BE] refactor: s3 업로드 된 이미지 받는걸로 수정
4 participants
@wugawuga @Go-Jaecheol @70825 @hanueleee