[AN/USER] 디자인 수정 및 Domain Exception 추가 (#978) #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
EmilyCh0
approved these changes
May 19, 2024
| package com.festago.festago.domain.exception | ||
|
|
||
| object BookmarkLimitExceededException : Exception() { | ||
| private fun readResolve(): Any = BookmarkLimitExceededException |
There was a problem hiding this comment.
object는 다음과 같은 이유때문에 필요하다고 합니다!
There was a problem hiding this comment.
아직 담고 있는 변수가 없어서 object로 바꿧는데 워닝 피하는 용도로 사용했습니다! 자세한 내용은 찾아서 올리겠습니다!
There was a problem hiding this comment.
Exception 이 클래스라서 상속받은 것도 클래스인게 일반적이지 않을까요?
메세지랑 상관없이 싱글톤으로 존재하지 않아도 될 것 같아요..!
Comment on lines
+132
to
+138
| if (it.isUnauthorized()) { | ||
| _event.emit(BookmarkFailure("로그인이 필요해요")) | ||
| } | ||
| if (it.isBookmarkLimitExceeded()) { | ||
| _uiState.value = uiState.copy(bookMarked = false) | ||
| _event.emit(BookmarkFailure("북마크는 12개까지 가능해요")) | ||
| } |
There was a problem hiding this comment.
북마크 할 때도 isNetworkError 처리할 수 있을까요? 북마크 시에는 인터넷 연결이 끊겨도 문제 없이 북마크 되는 것처럼 보입니다. (실제로 북마크 처리 되는 건 아니지만..)
There was a problem hiding this comment.
반영했습니다! 추가로 인터넷 문구가 너무 긴거 같아서 "인터넷 연결을 확인해주세요"으로 변경했습니다! 어떠신가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
Screen_recording_20240519_123412.webm