[BE] feat: 라인업이 공개된 축제가 인기 라인업으로 검색되게 변경 (#971) #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/test/java/com/festago/festival/application/integration/query/PopularFestivalV1QueryServiceIntegrationTest.java
Test Results240 files 240 suites 28s ⏱️ Results for commit 4a47d1e. ♻️ This comment has been updated with latest results. |
seokjin8678
requested changes
May 15, 2024
| @@ -38,6 +38,7 @@ public List<FestivalV1Response> findPopularFestivals() { | |||
| festivalQueryInfo.artistInfo) | |||
| ) | |||
| .from(festival) | |||
| .where(festivalQueryInfo.artistInfo.ne("[]")) | |||
There was a problem hiding this comment.
끝난 축제가 보인다는 피드백이 있어서, 해당 내용도 반영해야 할 것 같네요!
.where(festival.festivalDuration.endDate.gt(now)
.and((festivalQueryInfo.artistInfo.ne("[]"))))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용