Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN/USER] fix: 지역별 필터, 기타 디자인 수정(#969) #970

Merged
merged 9 commits into from
May 19, 2024

Conversation

EmilyCh0
Copy link
Member

@EmilyCh0 EmilyCh0 commented May 15, 2024

📌 관련 이슈

✨ PR 세부 내용

  • 지역별 필터 바텀시트 간격 수정
  • 지역별 필터 텍스트 색상 수정
  • 지역별 필터 선택 해제 버그 수정
  • 아티스트 상세에 회색 선 추가 및 간격 수정
  • 하단 네비게이션에 회색 선 추가
  • 하단 네비게이션 검색 아이콘 수정

+ 추가

  • 북마크 학교/아티스트 텍스트 잘림 해결
  • 요즘 뜨는 축제 폰트 스타일 H1으로 변경

지역별 필터 바텀시트
image
하단 네비
image

@EmilyCh0 EmilyCh0 added AN 안드로이드에 관련된 작업 USER labels May 15, 2024
@EmilyCh0 EmilyCh0 self-assigned this May 15, 2024
@github-actions github-actions bot requested review from re4rk and SeongHoonC May 15, 2024 10:36
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@@ -127,19 +127,25 @@
app:layout_constraintTop_toBottomOf="@id/tvArtistName"
app:singleLine="true" />

<com.google.android.material.divider.MaterialDivider
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaterialDivider 라는게 있군요 처음알았네요 ㅋㅋ

@@ -127,19 +127,25 @@
app:layout_constraintTop_toBottomOf="@id/tvArtistName"
app:singleLine="true" />

<com.google.android.material.divider.MaterialDivider
android:id="@+id/md_divider"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카멜 케이스만 수정 부탁드립니다!!

Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilyCh0 EmilyCh0 merged commit 0468778 into dev May 19, 2024
4 checks passed
@EmilyCh0 EmilyCh0 deleted the feat/#969 branch May 19, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AN 안드로이드에 관련된 작업 USER
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[AN] 지역별 필터, 기타 디자인 수정
3 participants