[BE] refactor: OpenIdUserInfoProvider 삭제 및 OpenIdClient에 비즈니스 로직 구현 (#950) #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results228 files 228 suites 28s ⏱️ Results for commit 8391719. ♻️ This comment has been updated with latest results. |
|
리뷰 기간이 지났기에 머지 처리 하도록 하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
이슈 내용 처럼
OpenIdUserInfoProvider인터페이스를 삭제하고, 해당 인터페이스를 구현하고 있는KakaoOpenIdUserInfoProvider에 있는 비즈니스 로직을KakaoOpenIdClient로 이동시켰습니다.특별히 위임을 하면서 까지 얻을 수 있는 장점이 크게 보이진 않더라구요. 😂
추후
AppleOpenIdClient가 새로 생긴다면 뭔가 있을 수 있겠지만, OpenID Connect가 표준 방식이라, 리팩터링한 방법처럼OpenIdClient에 비즈니스 로직이 모두 담길 것 같네요.