[AN/USER] feat: 카카오 로그인 및 토큰 관리(#861) #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # android/festago/data/src/main/java/com/festago/festago/data/di/singletonscope/RepositoryModule.kt # android/festago/presentation/src/main/res/values/strings.xml
Closed
2 tasks
re4rk
approved these changes
Apr 29, 2024
| } | ||
| } | ||
|
|
||
| private fun initWindowInsets() { |
There was a problem hiding this comment.
함수 분리 하신걸 보고 떠올린건데 여기저기 같은 기능을 필요로 하는 곳이 많은 것 같네요! 추후에 분리하는건 어떻게 생각하시나요??
There was a problem hiding this comment.
좋습니다. 반복이 생기면 분리해서 같이 사용하는게 좋아보여요. :)
SeongHoonC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용