Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] feat: 에러 화면, 새로고침 적용 (#898) #899

Merged
merged 6 commits into from
Apr 29, 2024
Merged

[AN/USER] feat: 에러 화면, 새로고침 적용 (#898) #899

merged 6 commits into from
Apr 29, 2024

Conversation

EmilyCh0
Copy link
Member

📌 관련 이슈

✨ PR 세부 내용

FestivalList / FestivalDetail / SchoolDetail / Search 화면에 에러 화면과 새로 고침 기능을 추가했습니다.

image

@EmilyCh0 EmilyCh0 added AN 안드로이드에 관련된 작업 USER labels Apr 27, 2024
@EmilyCh0 EmilyCh0 self-assigned this Apr 27, 2024
@github-actions github-actions bot requested review from re4rk and SeongHoonC April 27, 2024 15:25
SeongHoonC
SeongHoonC approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 동작하는 것을 확인했습니다.
검색 시 한 글자일 때 에러처리가 필요해서 그 부분은 새로 이슈 파서 작업하겠습니다!

@EmilyCh0 EmilyCh0 changed the title [AN/USER] feat: 에러 화면, 새로고침 적용 [AN/USER] feat: 에러 화면, 새로고침 적용 (#898) Apr 28, 2024
re4rk
re4rk approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@SeongHoonC SeongHoonC merged commit cb9bbc9 into dev Apr 29, 2024
5 checks passed
@SeongHoonC SeongHoonC deleted the feat/#898 branch April 29, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeongHoonC SeongHoonC SeongHoonC approved these changes

@re4rk re4rk re4rk approved these changes

Assignees

@EmilyCh0 EmilyCh0

Labels
AN 안드로이드에 관련된 작업 USER
Projects
2023-festa-go
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] 에러 화면을 적용한다.
3 participants
@EmilyCh0 @re4rk @SeongHoonC