Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: AdminStageV1Controller에 공연 단건 조회 기능 추가 (#855) #856

Merged
merged 6 commits into from
Apr 14, 2024

Conversation

seokjin8678
Copy link
Collaborator

@seokjin8678 seokjin8678 commented Apr 12, 2024

📌 관련 이슈

✨ PR 세부 내용

이슈 내용 그대로 AdminStageV1Controller에 공연의 식별자로 공연을 조회하는 기능을 추가했습니다.

AdminStageV1QueryServiceIntegrationTest에서 각 메서드 별 @Nested로 묶은 것 빼고는 크게 볼게 없을거라 생각되네요.

그 외 메서드 명을 어떻게 통일해야 하나 거슬리긴 하는데... 사소한 부분이니 나중에 운영 단계에서 리팩터링하면 좋을 것 같습니다.

@seokjin8678 seokjin8678 added BE 백엔드에 관련된 작업 ADMIN 📬 API API가 변경되거나 추가되는 작업 🏗️ 기능 기능 추가에 관한 작업 labels Apr 12, 2024
@seokjin8678 seokjin8678 self-assigned this Apr 12, 2024
@github-actions github-actions bot requested review from BGuga, carsago and xxeol2 April 12, 2024 05:35
Copy link

github-actions bot commented Apr 12, 2024

Test Results

194 files  194 suites   31s ⏱️
660 tests 660 ✅ 0 💤 0 ❌
673 runs  673 ✅ 0 💤 0 ❌

Results for commit c7a5b65.

♻️ This comment has been updated with latest results.

- 너무 긴 이름으로 인해 "Could not write XML test results for ..." 에러 수정
Copy link
Member

@BGuga BGuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어드민 페이지 수고 많으셨습니다!!

@seokjin8678 seokjin8678 merged commit 5071418 into dev Apr 14, 2024
3 checks passed
@seokjin8678 seokjin8678 deleted the feat/#855 branch April 14, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADMIN BE 백엔드에 관련된 작업 🏗️ 기능 기능 추가에 관한 작업 📬 API API가 변경되거나 추가되는 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] AdminStageController에 공연 단건 조회 기능을 추가한다.
3 participants