Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] feat: 축제 목록 화면 스크롤 민감도를 줄인다(#764) #765

Merged
merged 5 commits into from
Mar 6, 2024
Merged

[AN/USER] feat: 축제 목록 화면 스크롤 민감도를 줄인다(#764) #765

merged 5 commits into from
Mar 6, 2024

Conversation

SeongHoonC
Copy link
Member

@SeongHoonC SeongHoonC commented Feb 29, 2024 •
edited
Loading

📌 관련 이슈

✨ PR 세부 내용

refresh, viewPager, recyclerView 세가지가 중첩되어 있어서 생기는 문제를 해결했습니다.

  1. 리사이클러뷰를 상속받은 커스텀 리사이클러뷰를 사용합니다.
  2. swipeRefreshLayout 의 distanceToTriggerSync 속성을 120(default) 에서 400 으로 증가시켜 민감도를 낮췄습니다.

변경 전

KakaoTalk_Video_2024-02-29-13-52-28.mp4

변경 후

KakaoTalk_Video_2024-02-29-13-52-17.mp4

@SeongHoonC SeongHoonC added AN 안드로이드에 관련된 작업 USER labels Feb 29, 2024
@SeongHoonC SeongHoonC self-assigned this Feb 29, 2024
@SeongHoonC SeongHoonC linked an issue Feb 29, 2024 that may be closed by this pull request
[AN] 축제 목록 민감도를 줄인다 #764
Closed
@github-actions github-actions bot requested review from EmilyCh0 and re4rk February 29, 2024 04:46
EmilyCh0
EmilyCh0 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@EmilyCh0 EmilyCh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

re4rk
re4rk approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeongHoonC SeongHoonC merged commit 1f3cf51 into dev Mar 6, 2024
1 check passed
@SeongHoonC SeongHoonC deleted the feat/#764 branch March 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyCh0 EmilyCh0 EmilyCh0 approved these changes

@re4rk re4rk re4rk approved these changes

Assignees

@SeongHoonC SeongHoonC

Labels
AN 안드로이드에 관련된 작업 USER
Projects
2023-festa-go
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] 축제 목록 민감도를 줄인다
3 participants
@SeongHoonC @re4rk @EmilyCh0