[AN/USER] feat: 축제 목록 화면 페이징 작업(#673) #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
re4rk
approved these changes
Feb 23, 2024
| @@ -27,18 +32,24 @@ class FakeFestivalRepository @Inject constructor() : FestivalRepository { | |||
| val notNullSize = size ?: DEFAULT_SIZE | |||
| val notNullLastFestivalId = lastFestivalId ?: DEFAULT_LAST_FESTIVAL_ID | |||
There was a problem hiding this comment.
Suggested change
| val notNullLastFestivalId = lastFestivalId ?: DEFAULT_LAST_FESTIVAL_ID | |
| override suspend fun loadFestivals( | |
| schoolRegion: SchoolRegion?, | |
| festivalFilter: FestivalFilter?, | |
| lastFestivalId: Long?, | |
| lastStartDate: LocalDate = lastFestivalId ?: DEFAULT_LAST_FESTIVAL_ID, | |
| size: Int = DEFAULT_SIZE, | |
| ): Result<FestivalsPage> { |
과 같이 하지 않은 이유가 있었을까요?
There was a problem hiding this comment.
lastStartDate 에 lastFestivalId 를 넣는 이유가 무엇인가요..?
There was a problem hiding this comment.
아 오타가 났네요
override suspend fun loadFestivals(
schoolRegion: SchoolRegion?,
festivalFilter: FestivalFilter?,
lastFestivalId: Long = lastFestivalId ?: DEFAULT_LAST_FESTIVAL_ID,
lastStartDate: LocalDate?,
size: Int = DEFAULT_SIZE,
): Result<FestivalsPage> {이겁니다
There was a problem hiding this comment.
가능한 문법인가요..??
default value 에서 변수를 사용하거나 lastFestivalId 가 null 인 상황이 불가능합니다!
There was a problem hiding this comment.
또한 overriding function 은 허용되지 않는다고 하네요
There was a problem hiding this comment.
아 viewModel인줄 알았는데 fake 객체네요 ㅠㅠ 확인 잘못했습니다!
| @@ -34,14 +34,15 @@ class FestivalListViewModel @Inject constructor( | |||
|
|
|||
| fun loadFestivals(festivalFilterUiState: FestivalFilterUiState? = null) { | |||
There was a problem hiding this comment.
loadFestivals를 활용해서 무한스크롤이 동작하고 있는데 이 안에서 매번 pupularFestivals까지 로드되고 있습니다.
두 로직을 분리하는 것이 어떨까요?
There was a problem hiding this comment.
음..그렇네요 인기 축제 목록에 변화가 없어서 화면 변화는 없겠지만 불필요한 서버 요청을 줄여야겠어요!
# Conflicts: # android/festago/presentation/src/main/java/com/festago/festago/presentation/ui/home/festivallist/FestivalListFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
구성 변경 시 탭이 초기상태로 돌아가는 문제가 있어서 대응하였습니다.
1- 1. Success 아이템에 FestivalFilterUiState 추가하고 선택된 것에 맞춰서 탭이 선택됩니다.
축제 목록 페이징 작업하였습니다.
2-1. FestivalListMoreItemUiState 객체로 뷰타입을 활용해서 마지막에 추가합니다.
2-2. 스크롤 리스너로 마지막 아이템 도달 시 재요청합니다.
2-3. 뷰모델이 기존 리스트에 아이템을 추가해서 uiState 를 업데이트 합니다.