Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] fix: MockMailClient 빈으로 등록되는 프로파일 변경 (#542) #543

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

seokjin8678
Copy link
Collaborator

📌 관련 이슈

✨ PR 세부 내용

@Component
@Profile("!{dev|prod}")
public class MockMailClient implements MailClient {
    ...
}

스프링 5.1 이상 부터 정규식을 통해 프로파일을 설정할 수 있다고 하네요.
따라서 정규식을 사용하여 dev 또는 prod 프로파일이 아니면 해당 빈을 등록하도록 하였습니다.

@seokjin8678 seokjin8678 added BE 백엔드에 관련된 작업 🛠 수정 수정에 관련된 작업 labels Oct 13, 2023
@seokjin8678 seokjin8678 self-assigned this Oct 13, 2023
@github-actions github-actions bot requested review from BGuga, carsago and xxeol2 October 13, 2023 08:22
@github-actions
Copy link

Unit Test Results

  75 files    75 suites   13s ⏱️
234 tests 234 ✔️ 0 💤 0
238 runs  238 ✔️ 0 💤 0

Results for commit ce316fe.

@seokjin8678 seokjin8678 changed the title [BE] feat: MockMailClient 빈으로 등록되는 프로파일 변경 (#542) [BE] fix: MockMailClient 빈으로 등록되는 프로파일 변경 (#542) Oct 14, 2023
Copy link
Collaborator

@carsago carsago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

@BGuga BGuga merged commit 563b08e into dev Oct 15, 2023
8 checks passed
@BGuga BGuga deleted the feat/#542 branch October 15, 2023 14:42
BGuga pushed a commit that referenced this pull request Oct 17, 2023
* fix: dev, prod 프로파일이 아니면 등록되게 변경

* chore: 순서 변경
BGuga pushed a commit that referenced this pull request Oct 17, 2023
* fix: dev, prod 프로파일이 아니면 등록되게 변경

* chore: 순서 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드에 관련된 작업 🛠 수정 수정에 관련된 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] MockMailClient가 빈으로 등록되는 프로파일을 변경한다.
3 participants