[AN/USER] feat: fcm 푸시 알림 구현 (#522) #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re4rk
requested changes
Oct 13, 2023
Comment on lines
25
to
31
| val notificationManager = | ||
| getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager | ||
| val channel = NotificationChannel( | ||
| FcmMessageType.ENTRY_ALERT.channelId, | ||
| getString(R.string.entry_alert_channel_name), | ||
| NotificationManager.IMPORTANCE_DEFAULT | ||
| ) |
There was a problem hiding this comment.
Suggested change
| val notificationManager = | |
| getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager | |
| val channel = NotificationChannel( | |
| FcmMessageType.ENTRY_ALERT.channelId, | |
| getString(R.string.entry_alert_channel_name), | |
| NotificationManager.IMPORTANCE_DEFAULT | |
| ) | |
| val channel = NotificationChannel( | |
| FcmMessageType.ENTRY_ALERT.channelId, | |
| getString(R.string.entry_alert_channel_name), | |
| NotificationManager.IMPORTANCE_DEFAULT | |
| ) | |
| val notificationManager = | |
| getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager |
사용하기 직전에 꺼내오는 것이 어떨까요??
Comment on lines
39
to
42
| if (ActivityCompat.checkSelfPermission( | ||
| context, | ||
| android.Manifest.permission.POST_NOTIFICATIONS | ||
| ) == PackageManager.PERMISSION_GRANTED |
There was a problem hiding this comment.
이부분도 PermissionUtil안에서 Activity.Compat.checkPermission으로 빼내는 것이 어떨까요??
|
|
||
| ENTRY_PROCESS.channelId -> { | ||
| runBlocking { | ||
| // TODO: 입장완료 로직인지 확인하는 로직 추가 필요 |
There was a problem hiding this comment.
ENTRY_PROCESS.channelId으로 입력받았을 때 이 TODO가 해결 됐다고 생각하는데 어떻게 보시나요??
|
|
||
| override fun onMessageReceived(remoteMessage: RemoteMessage) { | ||
| when (remoteMessage.notification?.channelId) { | ||
| ENTRY_ALERT.channelId -> { |
There was a problem hiding this comment.
processEntryAlert나 handleEntryAlert로 빼내는 것은 어떤가요??
SeongHoonC
requested changes
Oct 16, 2023
Comment on lines
+16
to
+25
| private val intent = HomeActivity.getIntent(context).apply { | ||
| flags = Intent.FLAG_ACTIVITY_SINGLE_TOP or Intent.FLAG_ACTIVITY_CLEAR_TASK | ||
| } | ||
|
|
||
| private val pendingIntent = PendingIntent.getActivity( | ||
| context, | ||
| HOME_REQUEST_CODE, | ||
| intent, | ||
| PendingIntent.FLAG_IMMUTABLE or PendingIntent.FLAG_UPDATE_CURRENT | ||
| ) |
There was a problem hiding this comment.
entryAlertNotificationBuilder 를 초기화하기 위해서만 필요한 것 같아요!
프로퍼티로 있는 이유가 있을까요?
There was a problem hiding this comment.
아까 논의한대로 프로퍼티로 가지고 있을 필요는 없지만 싱글톤으로 관리하기 위해서 이대로 둘게요!
|
|
||
| class TicketEntryService : FirebaseMessagingService() { | ||
|
|
||
| private val notificationManager by lazy { NotificationManager(this) } |
There was a problem hiding this comment.
Firebase Service 도 힐트로 주입할 수 있나요?
Comment on lines
29
to
40
| private val requestPermissionLauncher = registerForActivityResult( | ||
| ActivityResultContracts.RequestPermission(), | ||
| ) { isGranted: Boolean -> | ||
| if (!isGranted) { | ||
| Toast.makeText( | ||
| this, | ||
| getString(R.string.home_notification_permission_denied), | ||
| Toast.LENGTH_SHORT | ||
| ).show() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
함수로 분리해서 내부 프로퍼티 제거했습니다!
# Conflicts: # android/festago/app/src/main/java/com/festago/festago/presentation/ui/home/HomeActivity.kt
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
* feat: 공연 입장 푸시 알림 구현 * refactor: FcmMessageType 분리 * refactor: NotificationManager 분리 * refactor: application에서 채널 생성 * fix: 포그라운드 푸시 알림 버그 해결 * refactor: 알림 권한 거부 메시지 문자열 추출 * refactor: ktlintCheck * move: fcm 관련 파일 패키지 변경 * refactor: 알림 권한 메서드 분리 * refactor: ktlintcheck * refactor: notificationManager 코드 순서 변경 * refactor: 불필요한 주석 제거 * refactor: 메서드 분리 * refactor: 알림 권한 확인 메서드 분리 * refactor: 알림 권한 요청 메서드 분리 * refactor: ktlintcheck
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
* feat: 공연 입장 푸시 알림 구현 * refactor: FcmMessageType 분리 * refactor: NotificationManager 분리 * refactor: application에서 채널 생성 * fix: 포그라운드 푸시 알림 버그 해결 * refactor: 알림 권한 거부 메시지 문자열 추출 * refactor: ktlintCheck * move: fcm 관련 파일 패키지 변경 * refactor: 알림 권한 메서드 분리 * refactor: ktlintcheck * refactor: notificationManager 코드 순서 변경 * refactor: 불필요한 주석 제거 * refactor: 메서드 분리 * refactor: 알림 권한 확인 메서드 분리 * refactor: 알림 권한 요청 메서드 분리 * refactor: ktlintcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용