[AN/USER] 티켓 제시 화면 2개 버그 해결 (#519) #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SeongHoonC
approved these changes
Oct 8, 2023
Comment on lines
+69
to
+73
| TicketEntryService.ticketStateChangeEvent.first { | ||
| Toast.makeText(this, "티켓이 스캔되었습니다.", Toast.LENGTH_SHORT).show() | ||
| setResult(RESULT_OK, intent) | ||
| finish() | ||
| true |
There was a problem hiding this comment.
넵 collect나 collectLast를 하면 티켓이 스캔되었습니다! 가 계속 뜨게 됩니다!
Comment on lines
+69
to
+73
| private fun setTimer(ticketId: Long, ticketCode: TicketCode) { | ||
| viewModelScope.launch { | ||
| timer.timerListener = createTimerListener(ticketId) | ||
| timer.start(ticketCode.period) | ||
| } |
There was a problem hiding this comment.
정확한 이유는 모르겠으나 combine안에서 timer를 호출하게 된다면 다른 corutineScope안에서 타이머가 동작하게 되어서 문제가 생기게 되었다고 보고있습니다!
EmilyCh0
approved these changes
Oct 8, 2023
Comment on lines
+69
to
+73
| private fun setTimer(ticketId: Long, ticketCode: TicketCode) { | ||
| viewModelScope.launch { | ||
| timer.timerListener = createTimerListener(ticketId) | ||
| timer.start(ticketCode.period) | ||
| } |
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용