Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] fix: SwipeRefresh 무한 로딩 버그 수정 (#514) #516

Merged
merged 4 commits into from
Oct 7, 2023
Merged

[AN/USER] fix: SwipeRefresh 무한 로딩 버그 수정 (#514) #516

merged 4 commits into from
Oct 7, 2023

Conversation

EmilyCh0
Copy link
Member

@EmilyCh0 EmilyCh0 commented Oct 7, 2023

📌 관련 이슈

✨ PR 세부 내용

  • uiState 값이 변경되지 않았을 때 collect가 발생하지 않아 무한 로딩하는 버그 수정했습니다.
  • 축제 목록, 마이페이지, 티켓 목록, 축제 상세 화면

@EmilyCh0 EmilyCh0 added AN 안드로이드에 관련된 작업 USER 🐛 버그 버그에 관련된 작업 labels Oct 7, 2023
@EmilyCh0 EmilyCh0 self-assigned this Oct 7, 2023
@github-actions github-actions bot requested review from re4rk and SeongHoonC October 7, 2023 06:16
SeongHoonC
SeongHoonC approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

re4rk
re4rk approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EmilyCh0 EmilyCh0 merged commit a7f4d77 into dev Oct 7, 2023
6 checks passed
@EmilyCh0 EmilyCh0 deleted the feat/#514 branch October 7, 2023 07:01
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@EmilyCh0 @BGuga
[AN/USER] fix: SwipeRefresh 무한 로딩 버그 수정 (#514) (#516)
965f3b6 
* fix: 축제 목록 swipe refresh 수정

* fix: 마이페이지 swipe refresh 수정

* fix: 티켓 목록 swipe refresh 수정

* fix: 축제 상세 swipe refresh 수정
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@EmilyCh0 @BGuga
[AN/USER] fix: SwipeRefresh 무한 로딩 버그 수정 (#514) (#516)
df1ff0f 
* fix: 축제 목록 swipe refresh 수정

* fix: 마이페이지 swipe refresh 수정

* fix: 티켓 목록 swipe refresh 수정

* fix: 축제 상세 swipe refresh 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeongHoonC SeongHoonC SeongHoonC approved these changes

@re4rk re4rk re4rk approved these changes

Assignees

@EmilyCh0 EmilyCh0

Labels
AN 안드로이드에 관련된 작업 USER 🐛 버그 버그에 관련된 작업
Projects
2023-festa-go
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] SwipeRefresh 무한 로딩 버그 수정
3 participants
@EmilyCh0 @re4rk @SeongHoonC