Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] Json convert시 생긴 에러 Catch 하도록 수정 (#509) #510

Merged
merged 14 commits into from
Oct 7, 2023
Merged

[AN/USER] Json convert시 생긴 에러 Catch 하도록 수정 (#509) #510

merged 14 commits into from
Oct 7, 2023

Conversation

re4rk
Copy link
Collaborator

@re4rk re4rk commented Oct 6, 2023 •
edited
Loading

📌 관련 이슈

✨ PR 세부 내용

  • Json convert시 생기는 에러 처리를 위한 새로운 함수 생성
    • runCatchingResponse
    • onSuccessOrCatch
  • 모든 Repository 해당 함수를 사용하도록 리팩토링

re4rk added 10 commits October 6, 2023 20:47
@re4rk
refactor: Result 내부 Value Convert하는 확장함수 추가
805c35c
@re4rk
refactor: 확장함수가 아닌 Block을 받아서 Convert 하도록 코드 수정
cf0b4e9
@re4rk
refactor: FestivalDefault 내부 함수에서 터지더라도 Catch 할 수 있도록 변경
fe85d27
@re4rk
refactor: tryConvert 네이밍 변경
b0ed197
@re4rk
refactor: 티켓 리포지터리 변경된 함수로 값을 받아오도록 변경
f593775
@re4rk
refactor: 학교 리포지터리 변경된 함수로 값을 받아오도록 변경
e2abd4f
@re4rk
refactor: 학생 리포지터리 변경된 함수로 값을 받아오도록 변경
737d755
@re4rk
refactor: 유저 리포지터리 변경된 함수로 값을 받아오도록 변경
bb7d549
@re4rk
refactor: 예약 리포지터리 변경된 함수로 값을 받아오도록 변경
49a2535
@re4rk
refactor: 토큰 리포지터리 변경된 함수로 값을 받아오도록 변경
5b2b5eb
@re4rk re4rk added AN 안드로이드에 관련된 작업 USER 🛠 수정 수정에 관련된 작업 labels Oct 6, 2023
@re4rk re4rk self-assigned this Oct 6, 2023
@re4rk re4rk linked an issue Oct 6, 2023 that may be closed by this pull request
[AN] Json convert시 생긴 에러 Catch 하도록 수정 #509
Closed
@re4rk re4rk marked this pull request as ready for review October 6, 2023 11:59
EmilyCh0
EmilyCh0 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@EmilyCh0 EmilyCh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다 👍 리포지토리 깔끔해져서 속시원하네요

SeongHoonC
SeongHoonC approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다! ㅎㅎ 이름도 마음에 드네요!

@re4rk re4rk merged commit 52e3142 into dev Oct 7, 2023
1 check passed
@re4rk re4rk deleted the feat/#509 branch October 7, 2023 04:29
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@re4rk @BGuga
[AN/USER] Json convert시 생긴 에러 Catch 하도록 수정 (#509) (#510)
2e29ecd
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@re4rk @BGuga
[AN/USER] Json convert시 생긴 에러 Catch 하도록 수정 (#509) (#510)
2ed29aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeongHoonC SeongHoonC SeongHoonC approved these changes

@EmilyCh0 EmilyCh0 EmilyCh0 approved these changes

Assignees

@re4rk re4rk

Labels
AN 안드로이드에 관련된 작업 USER 🛠 수정 수정에 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] Json convert시 생긴 에러 Catch 하도록 수정
3 participants
@re4rk @EmilyCh0 @SeongHoonC