Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면) (#497) #506

Merged
merged 4 commits into from
Oct 7, 2023
Merged

[AN/USER] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면) (#497) #506

merged 4 commits into from
Oct 7, 2023

Conversation

SeongHoonC
Copy link
Member

📌 관련 이슈

✨ PR 세부 내용

테스트 코드에서 given 절을 함수로 분리

@SeongHoonC SeongHoonC added AN 안드로이드에 관련된 작업 USER ⚙️ 리팩터링 리팩터링에 관련된 작업 labels Oct 6, 2023
@SeongHoonC SeongHoonC linked an issue Oct 6, 2023 that may be closed by this pull request
[AN] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면) #497
Closed
@SeongHoonC SeongHoonC self-assigned this Oct 6, 2023
@github-actions github-actions bot requested review from EmilyCh0 and re4rk October 6, 2023 06:56
EmilyCh0
EmilyCh0 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@EmilyCh0 EmilyCh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 LGTM

@re4rk
Copy link
Collaborator

re4rk commented Oct 7, 2023

LGTM!

@SeongHoonC SeongHoonC merged commit 1285924 into dev Oct 7, 2023
6 checks passed
@SeongHoonC SeongHoonC deleted the feat/#497 branch October 7, 2023 06:25
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@SeongHoonC @BGuga
[AN/USER] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면) (#497) (#506)
fbfd89e 
* refactor: 티켓 에매 테스트 given 리팩터링

* refactor: 홈 화면 테스트 given 절 분리

* refactor: 티켓 목록 화면 테스트 given 절 분리

* refactor: 티켓 기록 화면 테스트 given 절 분리
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@SeongHoonC @BGuga
[AN/USER] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면) (#497) (#506)
66c95a3 
* refactor: 티켓 에매 테스트 given 리팩터링

* refactor: 홈 화면 테스트 given 절 분리

* refactor: 티켓 목록 화면 테스트 given 절 분리

* refactor: 티켓 기록 화면 테스트 given 절 분리
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyCh0 EmilyCh0 EmilyCh0 approved these changes

@re4rk re4rk re4rk approved these changes

Assignees

@SeongHoonC SeongHoonC

Labels
AN 안드로이드에 관련된 작업 USER ⚙️ 리팩터링 리팩터링에 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] 테스트 코드 리팩터링 (티켓 목록, 티켓 예매, 티켓 기록, 홈화면)
3 participants
@SeongHoonC @re4rk @EmilyCh0