Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] feat: 학생 인증 API 연동(#456) #470

Merged
merged 7 commits into from
Sep 29, 2023
Merged

[AN/USER] feat: 학생 인증 API 연동(#456) #470

merged 7 commits into from
Sep 29, 2023

Conversation

SeongHoonC
Copy link
Member

📌 관련 이슈

✨ PR 세부 내용

학생 인증 연동 완료

이벤트 처리 완료

이메일 전송 실패 -> 이메일 확인 요청 이벤트 발생
타임 아웃 -> 시간 초과 이벤트 발생
인증 실패 -> 인증 실패 이벤트
인증 성공 -> 모든 액티비티 종료 후 메인 재시작

@SeongHoonC SeongHoonC added AN 안드로이드에 관련된 작업 USER labels Sep 27, 2023
@SeongHoonC SeongHoonC self-assigned this Sep 27, 2023
@SeongHoonC SeongHoonC linked an issue Sep 27, 2023 that may be closed by this pull request
[AN] 학생 인증 API 연동 #456
Closed
@github-actions github-actions bot requested review from EmilyCh0 and re4rk September 27, 2023 04:09
re4rk
re4rk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EmilyCh0
EmilyCh0 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@EmilyCh0 EmilyCh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 👍 handleUiState만 수정하고 머지해주세요!

@SeongHoonC SeongHoonC merged commit 2fcae35 into dev Sep 29, 2023
1 check passed
@SeongHoonC SeongHoonC deleted the feat/#456 branch September 29, 2023 13:47
re4rk pushed a commit that referenced this pull request Oct 5, 2023
@SeongHoonC @re4rk
[AN/USER] feat: 학생 인증 API 연동(#456) (#470)
b184ea8 
* feat: 학생 인증 저장소 API 연동

* fix: Request 이름 변경

* refactor: userName 으로 텍스트 가져오기 변경

* refactor: 인증 번호 위치 수정

* feat: 인증 화면 이벤트 처리

* refactor: uiState 타입 분기 변경
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@SeongHoonC @BGuga
[AN/USER] feat: 학생 인증 API 연동(#456) (#470)
fc62636 
* feat: 학생 인증 저장소 API 연동

* fix: Request 이름 변경

* refactor: userName 으로 텍스트 가져오기 변경

* refactor: 인증 번호 위치 수정

* feat: 인증 화면 이벤트 처리

* refactor: uiState 타입 분기 변경
BGuga pushed a commit that referenced this pull request Oct 17, 2023
@SeongHoonC @BGuga
[AN/USER] feat: 학생 인증 API 연동(#456) (#470)
74aff80 
* feat: 학생 인증 저장소 API 연동

* fix: Request 이름 변경

* refactor: userName 으로 텍스트 가져오기 변경

* refactor: 인증 번호 위치 수정

* feat: 인증 화면 이벤트 처리

* refactor: uiState 타입 분기 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyCh0 EmilyCh0 EmilyCh0 approved these changes

@re4rk re4rk re4rk approved these changes

Assignees

@SeongHoonC SeongHoonC

Labels
AN 안드로이드에 관련된 작업 USER
Projects
2023-festa-go
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] 학생 인증 API 연동
3 participants
@SeongHoonC @re4rk @EmilyCh0