[AN/USER] refactor: Hilt 적용(#453) #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SeongHoonC <[email protected]>
Co-authored-by: SeongHoonC <[email protected]>
Co-authored-by: SeongHoonC <[email protected]>
Co-authored-by: SeongHoonC <[email protected]>
Closed
Co-authored-by: SeongHoonC <[email protected]>
re4rk
approved these changes
Sep 20, 2023
| .build() | ||
|
|
||
| @Provides | ||
| @Singleton |
There was a problem hiding this comment.
반환 타입이 원시 타입이라 Qualifier를 미리 정의하는건 어떤가요??
There was a problem hiding this comment.
BaseUrlQualifier 추가 완료!
SeongHoonC
approved these changes
Sep 20, 2023
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
* chore: Hilt 의존성 추가 Co-authored-by: SeongHoonC <[email protected]> * feat: 의존성 주입 모듈 추가 Co-authored-by: SeongHoonC <[email protected]> * feat: 의존성 주입에 hilt 적용 Co-authored-by: SeongHoonC <[email protected]> * refactor: 사용하지 않는 수동 di 코드 삭제 Co-authored-by: SeongHoonC <[email protected]> * chore: ktlintcheck Co-authored-by: SeongHoonC <[email protected]> * refactor: 불필요한 어노테이션 제거 * refactor: 뷰모델 스코프 모듈 분리 * chore: 싱글톤 모듈 패키지 이동 * refactor: BaseUrlQualifier 추가 --------- Co-authored-by: SeongHoonC <[email protected]>
BGuga
pushed a commit
that referenced
this pull request
Oct 17, 2023
* chore: Hilt 의존성 추가 Co-authored-by: SeongHoonC <[email protected]> * feat: 의존성 주입 모듈 추가 Co-authored-by: SeongHoonC <[email protected]> * feat: 의존성 주입에 hilt 적용 Co-authored-by: SeongHoonC <[email protected]> * refactor: 사용하지 않는 수동 di 코드 삭제 Co-authored-by: SeongHoonC <[email protected]> * chore: ktlintcheck Co-authored-by: SeongHoonC <[email protected]> * refactor: 불필요한 어노테이션 제거 * refactor: 뷰모델 스코프 모듈 분리 * chore: 싱글톤 모듈 패키지 이동 * refactor: BaseUrlQualifier 추가 --------- Co-authored-by: SeongHoonC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
현재 전부 Singleton, SingletonComponent-> ViewModelComponent와 Singleton 아닌 것 분리