feat: School domain 유니크 제약조건 삭제

woowacourse-teams · May 8, 2024 · 06209bc · 06209bc
1 parent 5ba8311
commit 06209bc
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 19 deletions.
diff --git a/backend/src/main/java/com/festago/school/application/SchoolCommandService.java b/backend/src/main/java/com/festago/school/application/SchoolCommandService.java
@@ -30,11 +30,7 @@ public Long createSchool(SchoolCreateCommand command) {
     }
 
     private void validateCreate(SchoolCreateCommand command) {
-        String domain = command.domain();
         String name = command.name();
-        if (schoolRepository.existsByDomain(domain)) {
-            throw new BadRequestException(ErrorCode.DUPLICATE_SCHOOL_DOMAIN);
-        }
         if (schoolRepository.existsByName(name)) {
             throw new BadRequestException(ErrorCode.DUPLICATE_SCHOOL_NAME);
         }
@@ -55,11 +51,7 @@ public void updateSchool(Long schoolId, SchoolUpdateCommand command) {
     }
 
     private void validateUpdate(School school, SchoolUpdateCommand command) {
-        String domain = command.domain();
         String name = command.name();
-        if (!Objects.equals(school.getDomain(), domain) && schoolRepository.existsByDomain(domain)) {
-            throw new BadRequestException(ErrorCode.DUPLICATE_SCHOOL_DOMAIN);
-        }
         if (!Objects.equals(school.getName(), name) && schoolRepository.existsByName(name)) {
             throw new BadRequestException(ErrorCode.DUPLICATE_SCHOOL_NAME);
         }

diff --git a/backend/src/main/java/com/festago/school/domain/School.java b/backend/src/main/java/com/festago/school/domain/School.java
@@ -30,7 +30,6 @@ public class School extends BaseTimeEntity {
 
     @NotNull
     @Size(max = MAX_DOMAIN_LENGTH)
-    @Column(unique = true)
     private String domain;
 
     @NotNull

diff --git a/backend/src/main/resources/db/migration/V4__remove_school_unique_domain.sql b/backend/src/main/resources/db/migration/V4__remove_school_unique_domain.sql
@@ -0,0 +1,2 @@
+alter table school
+    drop key unique_domain;
diff --git a/backend/src/test/java/com/festago/school/application/SchoolCommandServiceTest.java b/backend/src/test/java/com/festago/school/application/SchoolCommandServiceTest.java
@@ -46,14 +46,15 @@ class createSchool {
             .build();
 
         @Test
-        void 같은_도메인의_학교가_저장되어_있으면_예외가_발생한다() {
+        void 같은_도메인의_학교가_저장되어_있어도_예외가_발생하지_않는다() {
             // given
             schoolRepository.save(SchoolFixture.builder().domain("teco.ac.kr").build());
 
-            // when & then
-            assertThatThrownBy(() -> schoolCommandService.createSchool(command))
-                .isInstanceOf(BadRequestException.class)
-                .hasMessage(ErrorCode.DUPLICATE_SCHOOL_DOMAIN.getMessage());
+            // when
+            Long schoolId = schoolCommandService.createSchool(command);
+
+            // then
+            assertThat(schoolRepository.getOrThrow(schoolId).getDomain()).isEqualTo("teco.ac.kr");
         }
 
         @Test
@@ -113,15 +114,16 @@ void setUp() {
         }
 
         @Test
-        void 같은_도메인의_학교가_저장되어_있으면_예외가_발생한다() {
+        void 같은_도메인의_학교가_저장되어_있어도_예외가_발생하지_않는다() {
             // given
             Long schoolId = school.getId();
             schoolRepository.save(SchoolFixture.builder().domain("teco.ac.kr").build());
 
-            // when & then
-            assertThatThrownBy(() -> schoolCommandService.updateSchool(schoolId, command))
-                .isInstanceOf(BadRequestException.class)
-                .hasMessage(ErrorCode.DUPLICATE_SCHOOL_DOMAIN.getMessage());
+            // when
+            schoolCommandService.updateSchool(schoolId, command);
+
+            //  then
+            assertThat(schoolRepository.getOrThrow(schoolId).getDomain()).isEqualTo("teco.ac.kr");
         }
 
         @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,6 @@ public class School extends BaseTimeEntity { @@
         @NotNull
         @Size(max = MAX_DOMAIN_LENGTH)
-        @Column(unique = true)
         private String domain;
         @NotNull
@@ Expand Down @@