-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sendReceiptAfterPayment and tapToPayEducation feature flags #14963
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PD: My physical device is pretty much like yours, tested w iPhone 14 on iOS 17.7.1. Any potential concern from iOS18?
Good question. The low likelihood concern is updated transitions from AboutView to TapToPayEducation sheets. Sometimes they do break when something changes between iOS versions. I will test it on a simulator. |
Description
AboutTapToPayView
, make renamings / replace withTapToPayEducationView
Steps to reproduce
The only meaningful change is replacing
AboutTapToPayView
withTapToPayEducationView
in two places:Testing information
Tested Tap to Pay and email flow on iPhone 14 Pro 17.7
Screenshots
Education.MP4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: