Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sendReceiptAfterPayment and tapToPayEducation feature flags #14963

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

staskus
Copy link
Collaborator

@staskus staskus commented Jan 23, 2025

Description

  • Remove sendReceiptAfterPayment and tapToPayEducation feature flags
  • Remove backendReceips feature flag - it has been enabled for a long time
  • Remove no longer needed code with AboutTapToPayView, make renamings / replace with TapToPayEducationView

Steps to reproduce

The only meaningful change is replacing AboutTapToPayView with TapToPayEducationView in two places:

  • Set Up Tap to Pay view
  • Set Up Tap to Pay complete view
  1. Open Menu
  2. Payments
  3. Tap 'Set Up Tap to Pay on iPhone'
  4. Tap 'Learn More' at the bottom
  5. Confirm education is opened
  6. Finish education by tapping 'Set Up Tap to Pay on iPhone'
  7. Confirm set up flow starts
  8. Complete the flow
  9. Confirm 'Setp complete' opens
  10. Tap 'Learn More' at the bottom
  11. Confirm education is opened

Testing information

Tested Tap to Pay and email flow on iPhone 14 Pro 17.7

Screenshots

Education.MP4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@staskus staskus added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Jan 23, 2025
@staskus staskus added this to the 21.5 milestone Jan 23, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 23, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@staskus staskus requested a review from iamgabrielma January 23, 2025 12:13
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 23, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14963-98bec1e
Version21.5
Bundle IDcom.automattic.alpha.woocommerce
Commit98bec1e
App Center BuildWooCommerce - Prototype Builds #12710
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot wpmobilebot modified the milestones: 21.5, 21.6 Jan 24, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.5 has now entered code-freeze, so the milestone of this PR has been updated to 21.6.

@iamgabrielma iamgabrielma self-assigned this Jan 27, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

PD: My physical device is pretty much like yours, tested w iPhone 14 on iOS 17.7.1. Any potential concern from iOS18?

@staskus
Copy link
Collaborator Author

staskus commented Jan 28, 2025

PD: My physical device is pretty much like yours, tested w iPhone 14 on iOS 17.7.1. Any potential concern from iOS18?

Good question. The low likelihood concern is updated transitions from AboutView to TapToPayEducation sheets. Sometimes they do break when something changes between iOS versions. I will test it on a simulator.

@staskus staskus merged commit ffd1e23 into trunk Jan 28, 2025
12 checks passed
@staskus staskus deleted the task/remove-ttp-education-feature-flags branch January 28, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants