[Brand Updates] Remove underline from links in the app #14938
Conversation
hichamboushaba
added
the
category: design
|
|
| @@ -2,7 +2,7 @@ import SwiftUI | |||
|
|
|||
| extension Color { | |||
|
|
|||
| static var accent: Color { | |||
| static var posAccent: Color { | |||
There was a problem hiding this comment.
This is the fix that I mentioned above, in a recent PR, I introduced this new property, and it resulted in an issue with the subtle button style that we use for "Write with AI" button:
My understanding of the issue: given that now we had UIColor.accent and Color.accent both in the app, the UIKitAttributes.foregroundColor started using the Color one, and ignore it at runtime, so to avoid any other similar issues, I'm renaming this property to make it clearer it's only for POS screens.
There was a problem hiding this comment.
Thanks for the explanation!
| @@ -92,7 +92,7 @@ struct AccountCreationForm: View { | |||
| .renderedIf(viewModel.currentField == .password) | |||
|
|
|||
| // Terms of Service link. | |||
| AttributedText(tosAttributedText, enablesLinkUnderline: true) | |||
There was a problem hiding this comment.
I'm not sure if we should remove the enableLinkUnderline completely now or not, WDYT?
There was a problem hiding this comment.
I am OK with keeping it inside AttributedText as a feature. IMO, cleaning up AttributedText sounds like it is out of scope for this project.
| @@ -2,7 +2,7 @@ import SwiftUI | |||
|
|
|||
| extension Color { | |||
|
|
|||
| static var accent: Color { | |||
| static var posAccent: Color { | |||
There was a problem hiding this comment.
Thanks for the explanation!
| @@ -92,7 +92,7 @@ struct AccountCreationForm: View { | |||
| .renderedIf(viewModel.currentField == .password) | |||
|
|
|||
| // Terms of Service link. | |||
| AttributedText(tosAttributedText, enablesLinkUnderline: true) | |||
There was a problem hiding this comment.
I am OK with keeping it inside AttributedText as a feature. IMO, cleaning up AttributedText sounds like it is out of scope for this project.
hichamboushaba
merged commit d0390ea
into
feature/woo-2.0-brand-updates
Part of: woocommerce/woomobile-private#413
Description
This PR removes all underlines from links in the app, except the login screens, where we need to wait until #14779 is merged.
The PR also adds another fix that I'll mention in the comments below.
Steps to reproduce
I think checking the screenshots below is enough (I tried to collect the screenshots of all the modified and still used screens in the app), but feel free to check the corresponding screens in the app too.
Testing information
Tested using iPhone 16 simulator, iOS 18.1
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: