Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACK week] Webhooks #14027

Draft
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Draft

[HACK week] Webhooks #14027

wants to merge 19 commits into from

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Sep 24, 2024

Description

HACK week project to implement the webhooks API into the mobile app.

Simulator Screen Recording - iPhone 15 - 2024-09-27 at 13 48 47

Screenshots

All webhooks (empty) All webhooks (some)
Simulator Screenshot - iPhone 15 - 2024-09-25 at 16 29 28 Simulator Screenshot - iPhone 15 - 2024-09-25 at 16 32 02
Create new (1) Create new (2)
Simulator Screenshot - iPhone 15 - 2024-09-25 at 16 32 11 Simulator Screenshot - iPhone 15 - 2024-09-25 at 16 32 14

Wp-admin:
Screenshot 2024-09-26 at 12 19 44

Payload in delivery URL:
Screenshot 2024-09-26 at 12 20 32

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 24, 2024

1 Error
🚫 Please ensure the PR has the category: tracks label.
1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
2 Messages
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 24, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14027-fab68ba
Version20.5
Bundle IDcom.automattic.alpha.woocommerce
Commitfab68ba
App Center BuildWooCommerce - Prototype Builds #11017
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iamgabrielma iamgabrielma added the type: task An internally driven task. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants