-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - CES Prompts Showing Several Times #1564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemd24
changed the title
Fix/1428 ces prompt remove notice
Fix - CES Prompts Showing Several Times
Jun 14, 2022
eason9487
reviewed
Jun 16, 2022
eason9487
reviewed
Jun 16, 2022
Thanks, @eason9487 for reviewing this! I have added your suggestions and I guess this is ready for another round! |
eason9487
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments. Tested locally with switching back and forth between GLA tabs and subpages, and it works well. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a follow-up of #1543 (comment)
The PR #1543, implemented a solution for the issue #1428, however, we found an issue with the bundle size and the package
@woocommerce/customer-effort-score
so we decided to hold the PR until the CES package is exporting theCustomerFeedbackModal
, see more context here: #1543 (comment) & #1543 (comment)This PR implements a workaround to fix:
Screenshots:
Before this PR:
Screen.Capture.on.2022-06-14.at.17-10-39.mp4
With this PR:
Screen.Capture.on.2022-06-14.at.17-03-10.mp4
Detailed test instructions:
wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&guide=campaign-creation-success
Additional details
Ideally, the CES prompt should be displayed on every page, as was mentioned in the following comment: #1543 (comment), unfortunately, this is not yet possible in the GLA app however we are looking into possible solutions like an AppShell #1548
cc: @ecgan @ianlin
Changelog entry