Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - CES Prompts Showing Several Times #1564

Merged
merged 12 commits into from
Jun 16, 2022

Conversation

jorgemd24
Copy link
Contributor

@jorgemd24 jorgemd24 commented Jun 14, 2022

Changes proposed in this Pull Request:

This is a follow-up of #1543 (comment)

The PR #1543, implemented a solution for the issue #1428, however, we found an issue with the bundle size and the package @woocommerce/customer-effort-score so we decided to hold the PR until the CES package is exporting the CustomerFeedbackModal, see more context here: #1543 (comment) & #1543 (comment)

This PR implements a workaround to fix:

Screenshots:

Before this PR:

Screen.Capture.on.2022-06-14.at.17-10-39.mp4

With this PR:

Screen.Capture.on.2022-06-14.at.17-03-10.mp4

Detailed test instructions:

  1. Go to wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&guide=campaign-creation-success
  2. Click on "Got it"
  3. One CES prompt should be displayed.
  4. Visit Edit free listings/Edit Ads Campaigns/Create Ads campaigns (the CES prompt should be gone)
  5. Return to the dashboard page and it should show only one CES prompt.
  6. Click on "Give Feedback", and the modal should be displayed

Additional details

Ideally, the CES prompt should be displayed on every page, as was mentioned in the following comment: #1543 (comment), unfortunately, this is not yet possible in the GLA app however we are looking into possible solutions like an AppShell #1548

cc: @ecgan @ianlin

Changelog entry

Fix - Multiple CES prompts on the Dashboard Page

@jorgemd24 jorgemd24 changed the title Fix/1428 ces prompt remove notice Fix - CES Prompts Showing Several Times Jun 14, 2022
@jorgemd24 jorgemd24 requested a review from a team June 14, 2022 16:01
@jorgemd24 jorgemd24 self-assigned this Jun 14, 2022
@jorgemd24 jorgemd24 marked this pull request as ready for review June 14, 2022 16:03
@jorgemd24
Copy link
Contributor Author

Thanks, @eason9487 for reviewing this! I have added your suggestions and I guess this is ready for another round!

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments. Tested locally with switching back and forth between GLA tabs and subpages, and it works well. LGTM.

@jorgemd24 jorgemd24 merged commit 43ab87a into develop Jun 16, 2022
@jorgemd24 jorgemd24 deleted the fix/1428-ces-prompt-remove-notice branch June 16, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants