Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana-mimir add subpkgs metaconvert, mimirtool, query-tee #39322

Merged
merged 6 commits into from
Jan 12, 2025

Conversation

nghiand16
Copy link
Contributor

Fixes:

Related: #39230

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the patch.

  1. can we consider bumping the epoch given we intend to build the package and associated subpackages again?
  2. can we expand on tests a little bit, I would also include --help if available and something like starting a server and grepping some logs (if possible)

grafana-mimir.yaml Outdated Show resolved Hide resolved
@nghiand16 nghiand16 force-pushed the grafana-mimir-add-subpkgs branch from 14b7237 to 0613a14 Compare January 11, 2025 10:44
@nghiand16
Copy link
Contributor Author

@kranurag7 I have updated PR. pls review

@kranurag7 kranurag7 added the approved-to-run A repo member has approved this external contribution label Jan 11, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 11, 2025
@nghiand16 nghiand16 force-pushed the grafana-mimir-add-subpkgs branch from ce37c46 to 5e36aa9 Compare January 12, 2025 03:14
grafana-mimir.yaml Outdated Show resolved Hide resolved
@nghiand16 nghiand16 force-pushed the grafana-mimir-add-subpkgs branch from 8788fed to c129710 Compare January 12, 2025 06:49
grafana-mimir.yaml Outdated Show resolved Hide resolved
@nghiand16 nghiand16 force-pushed the grafana-mimir-add-subpkgs branch from c129710 to 43b188b Compare January 12, 2025 06:54
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!! last comment on review side, yam needs to be run because linter is failing.

grafana-mimir.yaml Outdated Show resolved Hide resolved
grafana-mimir.yaml Outdated Show resolved Hide resolved
grafana-mimir.yaml Outdated Show resolved Hide resolved
@nghiand16 nghiand16 force-pushed the grafana-mimir-add-subpkgs branch from a82909c to d94816a Compare January 12, 2025 07:30
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!! looks good.

@kranurag7 kranurag7 merged commit e162b53 into wolfi-dev:main Jan 12, 2025
10 checks passed
@nghiand16
Copy link
Contributor Author

@kranurag7 yeah. thank you very much.
have nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants