-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana-mimir add subpkgs metaconvert, mimirtool, query-tee #39322
grafana-mimir add subpkgs metaconvert, mimirtool, query-tee #39322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the patch.
- can we consider bumping the epoch given we intend to build the package and associated subpackages again?
- can we expand on tests a little bit, I would also include
--help
if available and something like starting a server and grepping some logs (if possible)
14b7237
to
0613a14
Compare
@kranurag7 I have updated PR. pls review |
ce37c46
to
5e36aa9
Compare
8788fed
to
c129710
Compare
c129710
to
43b188b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!! last comment on review side, yam needs to be run because linter is failing.
a82909c
to
d94816a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again!! looks good.
@kranurag7 yeah. thank you very much. |
Fixes:
Related: #39230
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches