Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby3.3-async/2.21.1 package update #38188

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 21, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 21, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 21, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a structured analysis and solution:

• Detected Error:

patching file async.gemspec
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file async.gemspec.rej

• Error Category: Configuration/Patch

• Failure Point: The patch step in the pipeline, specifically trying to apply 001-remove-signing-key.patch

• Root Cause Analysis: The patch is failing to apply because the context lines in the patch file don't match the current version of the gemspec file. This typically happens when the upstream source has changed the file structure or content around line 11 of the gemspec.

• Suggested Fix:

  1. Update the patch file to match the new gemspec content:
# Get the current gemspec content
git show v2.21.1:async.gemspec > async.gemspec.new

# Create a new patch file
diff -u async.gemspec.new async.gemspec.modified > 001-remove-signing-key.patch

Or alternatively, modify the pipeline to skip signing instead of patching:

  - uses: ruby/build
    with:
      gem: ${{vars.gem}}
      options: "--no-sign"

• Explanation: The failure occurs because the patch content doesn't match the target file structure in version 2.21.1. Since the patch is likely trying to remove gem signing configuration, we can either update the patch to match the new file structure or skip signing altogether during the build process.

• Additional Notes:

  • Version 2.21.1 includes worker pool changes which might have resulted in gemspec modifications
  • The patch system requires exact context matches to apply successfully
  • Consider maintaining version-specific patches for major version changes

• References:

@Dentrax
Copy link
Member

Dentrax commented Dec 25, 2024

Superseded by #38187

@Dentrax Dentrax closed this Dec 25, 2024
@octo-sts octo-sts bot deleted the wolfictl-7064d0ba-b31c-4b26-87c0-72c925cb6dd7 branch December 26, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants