Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-cassandra-medusa: pin python version #38175

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dannf
Copy link
Contributor

@dannf dannf commented Dec 21, 2024

No description provided.

No functional change.

Signed-off-by: dann frazier <[email protected]>
It builds and tests fine w/o this.

Signed-off-by: dann frazier <[email protected]>
Remove the dependency on /usr/bin/python3 and /usr/bin/pip
being the same version of python that we are using by
using the versioned binaries. If an image needs python3
to be python3.11 for compat reasons, then they can install
python-3.11.

Signed-off-by: dann frazier <[email protected]>
Replace dependencies that py3.11-build-base provides
with py3.11-build-base.

Signed-off-by: dann frazier <[email protected]>
Otherwise apk will resolve the dependency using provide priorities,
and currently the python 3.13 version will win. That drags in an
entirely new python environment that we don't need.

Signed-off-by: dann frazier <[email protected]>
`sed -i` will replace a symlink with a full copy. Only run
it on regular files. This should make sure we're always
running the latest patched interpreter, as well as decrease
package and image sizes.

Signed-off-by: dann frazier <[email protected]>
Without this, our compat symlink dangles.

Signed-off-by: dann frazier <[email protected]>
@dannf dannf enabled auto-merge December 21, 2024 13:58
@dannf dannf added the approved-to-run A repo member has approved this external contribution label Dec 21, 2024
@dannf dannf disabled auto-merge December 21, 2024 14:09
@dannf dannf enabled auto-merge December 21, 2024 14:10

This comment was marked as off-topic.

…arm64

psutil, and possibly other module dependencies from PyPI, are not
pre-compiled for arm64, so we need the C build environment.

Signed-off-by: dann frazier <[email protected]>
@dannf dannf added the ai/skip-comment Stop AI from commenting on PR label Dec 21, 2024
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 21, 2024
@dannf dannf disabled auto-merge December 23, 2024 15:08
@dannf
Copy link
Contributor Author

dannf commented Dec 23, 2024

Closing in lieu of #38209

@dannf dannf closed this Dec 23, 2024
@dannf
Copy link
Contributor Author

dannf commented Dec 24, 2024

Reopening - let's try to just fix the python issues with this one, and we can discuss further how to deal with the security aspects in #38209

@dannf dannf reopened this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant