-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3-cassandra-medusa: pin python version #38175
Open
dannf
wants to merge
10
commits into
wolfi-dev:main
Choose a base branch
from
dannf:py3-cassandra-pin-python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change. Signed-off-by: dann frazier <[email protected]>
It builds and tests fine w/o this. Signed-off-by: dann frazier <[email protected]>
Remove the dependency on /usr/bin/python3 and /usr/bin/pip being the same version of python that we are using by using the versioned binaries. If an image needs python3 to be python3.11 for compat reasons, then they can install python-3.11. Signed-off-by: dann frazier <[email protected]>
Replace dependencies that py3.11-build-base provides with py3.11-build-base. Signed-off-by: dann frazier <[email protected]>
Otherwise apk will resolve the dependency using provide priorities, and currently the python 3.13 version will win. That drags in an entirely new python environment that we don't need. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
`sed -i` will replace a symlink with a full copy. Only run it on regular files. This should make sure we're always running the latest patched interpreter, as well as decrease package and image sizes. Signed-off-by: dann frazier <[email protected]>
Without this, our compat symlink dangles. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
dannf
added
the
approved-to-run
A repo member has approved this external contribution
label
Dec 21, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
…arm64 psutil, and possibly other module dependencies from PyPI, are not pre-compiled for arm64, so we need the C build environment. Signed-off-by: dann frazier <[email protected]>
octo-sts
bot
added
the
bincapz/pass
bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
label
Dec 21, 2024
Closing in lieu of #38209 |
Reopening - let's try to just fix the python issues with this one, and we can discuss further how to deal with the security aspects in #38209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ai/skip-comment
Stop AI from commenting on PR
approved-to-run
A repo member has approved this external contribution
bincapz/pass
bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.