-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc.yaml: Add openssf-options (and disable it) #32446
base: main
Are you sure you want to change the base?
glibc.yaml: Add openssf-options (and disable it) #32446
Conversation
a786f91
to
6828b6a
Compare
1affc2b
to
909ebc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @justinvreeland. I haven't had time to dig into the root cause yet, so let's go with this.
Would you mind adding a link to https://github.com/chainguard-dev/internal-dev/issues/7756 above the GCC_SPEC_FILE setting?
Should we guard this to only apply to the ARM builds?
926cbac
to
94770b7
Compare
Done.
I'm not sure if we can do that in the yaml tbh. But in general I prefer keeping things as close as possible in the architectures. Don't have particularly strong feelings about that though. |
Yeah, probably not in the
Fair enough, let's just merge this as-is. Thanks! |
Rebasing to see if that fixes whatever is stopping the merge |
94770b7
to
2dac188
Compare
@justinvreeland it seems that "maintainers can modify this PR" has been turned off; and we have no ability to re-run ci-sbom-validity. Either you need to rebase this PR, or I guess i can create a new one with hope of it passing ci checks. |
rebased PR here #38280 hopefully it will pass CI. |
No description provided.