adds a patch to use sha256 instead of md5 #14041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mritunjay <[email protected]>
rawlingsj
requested changes
Mar 4, 2024
|
@mritunjaysharma394 This looks great. Can you please submit this upstream? Or do you want me to do this? Cause if it is upstream, we don't need to maintain it ourselves downstream. |
|
Thanks a lot @xnox , that sounds a good idea, happy to submit this as PR in upstream, let's hope they like the idea too! |
|
Created PR and an issue in upstream for this opensearch-project/OpenSearch-Dashboards#6032 |
|
See review & feedback upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing upstream of opensearch-dashboard uses md5, this PR adds a patch to use more secure sha256 instead