fix(chromium): Add crashpad handler, enable ldd, add en-US locale to base package, and implement more tests #13921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing crashpad handler for catching exceptions and generating crash reports Signed-off-by: RJ Sampson <[email protected]>
ajayk
previously approved these changes
Mar 1, 2024
EyeCantCU
force-pushed
the
chromium-fixes
branch
from
4c9fdf2 to
2a1c8b9
Compare
Fixes linking between libraries (namely libui_qt) Signed-off-by: RJ Sampson <[email protected]>
Without at least one locale, Chromium is no-op out of the box Signed-off-by: RJ Sampson <[email protected]>
Given the scope of Chromium, it is beneficial to check whether or not libraries are properly linked Signed-off-by: RJ Sampson <[email protected]>
Ensures ChromeDriver works Signed-off-by: RJ Sampson <[email protected]>
EyeCantCU
force-pushed
the
chromium-fixes
branch
2 times, most recently
from
49be840 to
d28afec
Compare
Allows passing startup vars to Chromium via CHROMIUM_USER_FLAGS Signed-off-by: RJ Sampson <[email protected]>
EyeCantCU
force-pushed
the
chromium-fixes
branch
from
d28afec to
5d0a19a
Compare
Signed-off-by: RJ Sampson <[email protected]>
Signed-off-by: RJ Sampson <[email protected]>
ajayk
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Adds missing crashpad handler, fixes broken libui linking by enabling lld, and adds en-US locale to the base package.
Additionally, a couple tests have been implemented to help ensure Chromium is in a functioning state.