Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giflib/5.2.2 package update #13269

Merged
merged 5 commits into from
Apr 25, 2024
Merged

giflib/5.2.2 package update #13269

merged 5 commits into from
Apr 25, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Feb 19, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package "automated pr" labels Feb 19, 2024
@cpanato cpanato force-pushed the wolfictl-0af926c2-b660-4b39-bd15-b1769ee204b2 branch from 990d592 to 4418495 Compare April 23, 2024 17:11
@cpanato
Copy link
Member

cpanato commented Apr 23, 2024 •
edited
Loading 

2024/04/23 17:22:15 ERRO unresolvable cycle: libwebp:1.4.0-r0@local -> giflib-dev:5.2.2-r0@local, caused by: giflib-dev:5.2.2-r0@local -> giflib:5.2.2-r0@local -> imagemagick:7.1.1.31-r0@local -> libwebp-dev:1.4.0-r0@local -> libwebp:1.4.0-r0@local
Error: unable to build graph:
there is no single step to remove to clear from giflib-dev:5.2.2-r0@local to libwebp:1.4.0-r0@local
2024/04/23 17:22:16 INFO error during command execution: unable to build graph:
there is no single step to remove to clear from giflib-dev:5.2.2-r0@local to libwebp:1.4.0-r0@local

any tips? @rawlingsj @xnox

@xnox
Copy link
Member

xnox commented Apr 23, 2024

That's not a real cycle.

Without ABI breaks one can use new or old anywhere in the chain...

I am not sure why we are so strict, as building these in any order is fine. Or like build the loop twice if one really wants to.

@cpanato
Copy link
Member

cpanato commented Apr 24, 2024

That's not a real cycle.

Without ABI breaks one can use new or old anywhere in the chain...

I am not sure why we are so strict, as building these in any order is fine. Or like build the loop twice if one really wants to.

where can we fix this?

@xnox
Preconvert documentation logo, to avoid build-cycle loop on imagemagick
56bb943 
This should be reported upstream as well, as something very silly.

Signed-off-by: Dimitri John Ledkov <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Package giflib-doc: Click to expand/collapse

Package giflib-doc:
Added: /usr/share/doc/giflib/giffilter.1
Added: /usr/share/doc/giflib/giffilter.html
Added: /usr/share/doc/giflib/giffilter.xml
Added: /usr/share/doc/giflib/giflib-logo.gif
Added: /usr/share/doc/giflib/giflib.7
Added: /usr/share/doc/giflib/gifsponge.1
Added: /usr/share/doc/giflib/gifsponge.html
Added: /usr/share/doc/giflib/gifsponge.xml
Added: /usr/share/doc/giflib/whatsinagif/sample_2_animation.gif
Added: /usr/share/man/man1/gif2rgb.xml
Added: /usr/share/man/man1/gifbuild.xml
Added: /usr/share/man/man1/gifclrmp.xml
Added: /usr/share/man/man1/giffix.xml
Added: /usr/share/man/man1/giflib.xml
Added: /usr/share/man/man1/giftext.xml
Added: /usr/share/man/man1/giftool.xml
Modified: /usr/share/doc/giflib/Makefile
Modified: /usr/share/doc/giflib/gif2rgb.1
Modified: /usr/share/doc/giflib/gif2rgb.html
Modified: /usr/share/doc/giflib/gif2rgb.xml
Modified: /usr/share/doc/giflib/gif_lib.html
Modified: /usr/share/doc/giflib/gif_lib.xml
Modified: /usr/share/doc/giflib/gifbg.1
Modified: /usr/share/doc/giflib/gifbuild.1
Modified: /usr/share/doc/giflib/gifclrmp.1
Modified: /usr/share/doc/giflib/gifcolor.1
Modified: /usr/share/doc/giflib/gifecho.1
Modified: /usr/share/doc/giflib/giffix.1
Modified: /usr/share/doc/giflib/gifhisto.1
Modified: /usr/share/doc/giflib/gifinto.1
Modified: /usr/share/doc/giflib/gifinto.html
Modified: /usr/share/doc/giflib/gifinto.xml
Modified: /usr/share/doc/giflib/giflib.html
Modified: /usr/share/doc/giflib/giflib.xml
Modified: /usr/share/doc/giflib/giftext.1
Modified: /usr/share/doc/giflib/giftool.1
Modified: /usr/share/doc/giflib/gifwedge.1
Modified: /usr/share/doc/giflib/intro.html
Modified: /usr/share/doc/giflib/intro.xml
Modified: /usr/share/doc/giflib/whatsinagif/animation_and_transparency.html
Modified: /usr/share/doc/giflib/whatsinagif/bits_and_bytes.html
Modified: /usr/share/doc/giflib/whatsinagif/lzw_image_data.html
Deleted: /usr/share/doc/giflib/giflib.1
Deleted: /usr/share/doc/giflib/whatsinagif/highlight_green.gif
Deleted: /usr/share/doc/giflib/whatsinagif/highlight_purple.gif
Deleted: /usr/share/man/man1/gif2rgb.1
Deleted: /usr/share/man/man1/gifbg.1
Deleted: /usr/share/man/man1/gifbuild.1
Deleted: /usr/share/man/man1/gifclrmp.1
Deleted: /usr/share/man/man1/gifcolor.1
Deleted: /usr/share/man/man1/gifecho.1
Deleted: /usr/share/man/man1/giffix.1
Deleted: /usr/share/man/man1/gifhisto.1
Deleted: /usr/share/man/man1/gifinto.1
Deleted: /usr/share/man/man1/giflib.1
Deleted: /usr/share/man/man1/giftext.1
Deleted: /usr/share/man/man1/giftool.1
Deleted: /usr/share/man/man1/gifwedge.1

Package giflib-utils: Click to expand/collapse

Package giflib-utils:
Modified: /usr/bin/gif2rgb
Modified: /usr/bin/gifbuild
Modified: /usr/bin/gifclrmp
Modified: /usr/bin/giffix
Modified: /usr/bin/giftext
Modified: /usr/bin/giftool

Package giflib: Click to expand/collapse

Package giflib:
Modified: /usr/lib/libgif.so.7.2.0

Package giflib-dev: Click to expand/collapse

Package giflib-dev:
Modified: /usr/include/gif_lib.h

xnox
xnox approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@xnox xnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream is silly for introducing this loop. Unbreaking it with patching in the logo in the overlay.

@xnox
Copy link
Member

xnox commented Apr 25, 2024

Upstream added

# Logo image file for HTML docs
giflib-logo.gif: ../pic/gifgrid.gif
        convert $^ -resize 50x50 $@

When to achieve that..... convert links in a GIF processing library giflib..... which is itself.

cpanato
cpanato approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow thanks

@cpanato cpanato merged commit 66204c1 into main Apr 25, 2024
8 checks passed
@cpanato cpanato deleted the wolfictl-0af926c2-b660-4b39-bd15-b1769ee204b2 branch April 25, 2024 14:16
@xnox
Copy link
Member

xnox commented Apr 26, 2024 •
edited
Loading

btw this was reported by many other people to giflib upstream and they solved it independently, exactly the same way. So this patch/overlay can be dropped on next upstream release see https://sourceforge.net/p/giflib/code/ci/d54b45b0240d455bbaedee4be5203d2703e59967/

@ajayk @cpanato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xnox xnox xnox approved these changes

Assignees

@cpanato cpanato

Labels
request-version-update request for a newer version of a package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @xnox @wolfi-bot @ajayk