Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wget from default busybox config. #12631

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

smoser
Copy link
Member

@smoser smoser commented Feb 7, 2024

Wget is a http/https client. We have decided to remove it from the default busybox build as simply good hygiene.

Images that need a command line http client have the following options:

  • add curl package
  • add wget package
  • use busybox-full package instead of busybox.

Also note that ssl config option is dropped. This is because wget is the only thing that was pulling it in.

See also #12583

@smoser smoser force-pushed the cleanup/drop-wget-from-busybox branch from 096e1b7 to dbc4877 Compare February 7, 2024 16:46
@imjasonh
Copy link
Member

imjasonh commented Feb 7, 2024

I checked to be sure, and Melange's fetch pipeline uses the wget package itself, instead of depending on it being provided by busybox: https://github.com/chainguard-dev/melange/blob/a298935850e80ecdb2e05c094ac507939b2bca47/pkg/build/pipelines/fetch.yaml#L5

It looks like our Alpine-based busybox image relies on wget being provided by busybox, but that's unrelated to this change, since it's the Alpine-based image: https://github.com/chainguard-images/images/blob/f13ca95620c6dd251f421426b96edb87054824cf/images/busybox/config/alpine/main.tf#L14

@dlorenc
Copy link
Member

dlorenc commented Feb 7, 2024

I'm sure this will break something but it makes sense anyway.

@imjasonh
Copy link
Member

imjasonh commented Feb 7, 2024

We should make our images' dev variants include wget explicitly after this, and/or make it pull in busybox-full instead of just busybox

https://github.com/chainguard-images/images-private/blob/450a1910ec6436b9f69f2e607f52e2a9b9a3b589/tflib/publisher/main.tf#L101

@smoser smoser force-pushed the cleanup/drop-wget-from-busybox branch from dbc4877 to 73ac1d0 Compare February 7, 2024 18:59
Wget is a http/https client.  We have decided to remove it from
the default busybox build as simply good hygiene.

Images that need a command line http client have the following options:
 * add curl package
 * add wget package
 * use busybox-full package instead of busybox.

Also note that ssl config option is dropped.  This is because
wget is the only thing that was pulling it in.
Signed-off-by: Jason Hall <[email protected]>
@smoser smoser merged commit 2a81543 into wolfi-dev:main Feb 8, 2024
8 checks passed
@vaikas
Copy link
Member

vaikas commented Feb 8, 2024

#9187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants