merging APdev changes to mine #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test potential origin of bug It could be possible that cancelling these events has some adverse effects. * Disable old fix * Disable another potential origin * debug messages for monitoring * Potentially detect more piston events * fix events * detect processing * Test potential fix * Update IWorldHandler.java * Try to catch problems in the WorldHandler * Update IWorldHandler.java * Use NMS code to fix pistons * Update IWorldHandler.java * Remove old fixes and 1.21 implementation Also removed debug messages * Missed a debug message * Fix unintentional wildcard imports
* changed hardcoded sink limit to be dynamic Changed hardcoded sink limit from `y < 5` to `y < (craft.getWorld().getMinHeight() + 5)` preserving the original 4 block buffer but accounting for the new minimum world heights of 1.18+ * Adjusted X, Y, Z lengths by +1 Adjusted X, Y, Z, lengths by +1 to compensate for coordinate vs block math. * Fixed missing `. ` * fixed missing `)` too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
Related issues:
Checklist