Clarify that raw disables both decompression and decoding #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the docs for decoding I was confused like "Wait, what is the difference between `:raw` and `:decode_body` then?" And well that is it, searching for `:raw` more unveils it but I think since the option affects both steps mentioning both effects may be worth it :)
|
|
wojtekmach
reviewed
Dec 3, 2024
Co-authored-by: Wojtek Mach <[email protected]>
wojtekmach
reviewed
Dec 3, 2024
|
Thank you! |
|
lmao you were faster than me I just updated the other bit 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the docs for decoding I was confused like "Wait, what is the difference between
:rawand:decode_bodythen?" And well that is it, searching for:rawmore unveils it but I think since the option affects both steps mentioning both effects may be worth it :)Thanks for your excellent work on req! 💚