Add option to configure Finch pool :pool_max_idle_time #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a long-running app may want to make requests to arbitrary URLs (e.g. specified by the user). By default finch would start a separate pool for each host and keep it indefinitely, but this can be configured with the
:pool_max_idle_time
option.Initially I wanted to just use a custom finch pool and do
Req.new(finch: TransientFinchPool)
, however we also use:connect_options
, and these cannot be used together. Hence, I'm proposing to add the Finch pool option. Thoughts?