Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create car-mirror-reqwest crate & add high-level streaming functions #42

Merged
merged 15 commits into from
Feb 21, 2024

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Feb 19, 2024

TODO

  • Documentation for pull::handle_request_streaming and push::request_streaming
  • Module-level doctests in car-mirror to show how the request loop works
  • Module-level doctests in car-mirror-reqwest to show how to make a request against a simple axum server (this turned into a compilation doctest & the axum example instead)

@matheus23 matheus23 self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (bb5a166) 53.13% compared to head (498004e) 50.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   53.13%   50.65%   -2.48%     
==========================================
  Files          12       15       +3     
  Lines         559      758     +199     
  Branches      249      358     +109     
==========================================
+ Hits          297      384      +87     
- Misses         59       65       +6     
- Partials      203      309     +106     
Files Coverage Δ
car-mirror-reqwest/src/lib.rs 100.00% <100.00%> (ø)
car-mirror/src/cache.rs 60.41% <ø> (+2.08%) ⬆️
car-mirror/src/lib.rs 100.00% <ø> (ø)
car-mirror/src/incremental_verification.rs 52.94% <0.00%> (-0.64%) ⬇️
car-mirror/src/pull.rs 68.42% <68.42%> (ø)
car-mirror/src/push.rs 67.50% <66.66%> (-0.93%) ⬇️
car-mirror/src/test_utils/local_utils.rs 37.50% <0.00%> (-6.41%) ⬇️
car-mirror/src/common.rs 53.16% <34.78%> (-3.38%) ⬇️
car-mirror-reqwest/src/request.rs 54.23% <54.23%> (ø)
car-mirror-reqwest/integration/axum.rs 29.41% <29.41%> (ø)

... and 1 file with indirect coverage changes

@matheus23 matheus23 merged commit 206f6d8 into main Feb 21, 2024
10 of 11 checks passed
@matheus23 matheus23 deleted the matheus23/reqwest-crate branch February 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant