-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 674 #721
Conversation
… status of elasticsearch and disk usage fix issue 674 and 683
docker-compose.monitoring.yml
Outdated
@@ -108,6 +125,14 @@ services: | |||
<<: *logging | |||
elasticsearch: | |||
<<: *logging | |||
container_name: elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add another "elasticsearch"-services into the docker-compose.monitoring.yml ? I think this is a mistake and should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thats an error! I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Peiwen, I see several changes in the code that I think are related to local development and should be removed. Could you please add a screenshot of the new dashboard that you made ?
docker-compose.yml
Outdated
@@ -86,6 +87,8 @@ services: | |||
- "ES_JAVA_OPTS=-Xms512m -Xmx512m" | |||
- cluster.name=es-wis2box | |||
- xpack.security.enabled=false | |||
ports: | |||
- "9200:9200" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional port-mapping should not be required, please remove it
docker-compose.yml
Outdated
@@ -147,6 +150,8 @@ services: | |||
|
|||
wis2downloader: | |||
container_name: wis2downloader | |||
image: wis2box_project-wis2downloader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you define the image name to the downloader image ? should be removed
prometheus/prometheus.yml
Outdated
|
||
- job_name: 'prometheus' | ||
static_configs: | ||
- targets: ['localhost:9090'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this job do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this part it's useless
prometheus/prometheus.yml
Outdated
static_configs: | ||
- targets: ['localhost:9090'] | ||
|
||
- job_name: 'node_exporter' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the node_exporter for now
docker-compose.monitoring.yml
Outdated
ipv4_address: 10.5.0.2 | ||
default: | ||
|
||
node_exporter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the node-exporter for now
Yes, sure Maiike. Thanks for your correctness, let me change this part! |
Hi Peiwen, thank your for the screenshot. I think you can improve this dashboard for the wis2box-users: "alarmtracking dashboard" -> this is the title of the dashboard but you named the json file that defines it "metricsmonitoring.json" please be consistent and think of a proper title and filename , you should mention "Elasticsearch" if the metrics are based on Elasticsearch "disk space usage" -> what is the unit ? the Y-axis shows 3 times 27 which is confusing , can you please improve this "count of indices that have read_only_allow_delete=true" -> it is sufficient to display the current value for this metric, anything above 0 should be displayed in red What is the difference between "available space" and "free space" ? Are they both required for the user ? Please display bytes using a human-friendly unit (Grafana has built-in option to auto-convert bytes into kB/MB) the screenshots shows a range of "last 5 minutes" please define a sensible default for the default time-range finally think about the usage of colors in your dashboard, for example you can set thresholds in Grafana to make a bad value display as red, while good values can be displayed in green |
Sure, thanks for your review Maaike, let me impove it based on the comments. Will provide new version soon. |
…y to user's personal emails/friendly dashboard to users
Current Alerts Overview: Elasticsearch Disk Space Utilization: Available Disk Space (GB): Elasticsearch Disk Usage Thresholds: Read-Only Indices Count: |
make sure there is no conflict with main branch
remove the whitespace
updates shown in issue-674-new branch |
Fix issue 674 and issue 683:
Adding new dashboard in Grafana to monitor the status of elasticsearch health by using metrics:
Adding disk space usage status moniring and alert in new dashboard in Grafana
Optimize container relationship in wis2box to make sure when machine restart wis2box could bahave well in 1-2 minutes.