Update otp_credentials#show to redirect to new_session_path for blank challenge #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blank challenges (resolves "undefined method root_url" error);
strouptl
force-pushed
the
blank_challenge_redirect
branch
from
bea490c
to
4c982d3
Compare
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The otp_credentials#show action returns an "undefined method root_url" error for blank challenge or resource (which is acquired via the challenge), as there is no root path defined in the routes. It is probably better to redirect these requests to new_session_path anyway, though, as the update action does.
This PR makes this change and resolves the issue.