Add support for Rails 8, use Appraisal to test gem against older Rails versions #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-rodriguez
force-pushed
the
wip/rails8
branch
from
7645f78
to
7d5889b
Compare
|
ping @strzibny |
|
This PR fixes the error in CI https://github.com/wmlele/devise-otp/actions/runs/11869310036 |
…s versions See svenfuchs/rails-i18n#1130 (comment) for upper constraint removal
strzibny
reviewed
Nov 18, 2024
| @@ -1,4 +1,4 @@ | |||
| class CreateAdmins < ActiveRecord::Migration[7.1] | |||
| class CreateAdmins < ActiveRecord::Migration[5.0] | |||
There was a problem hiding this comment.
Otherwise migrations don't apply when running CI against Rails 7.0
There was a problem hiding this comment.
And to be consistent with other migrations
n-rodriguez
force-pushed
the
wip/rails8
branch
from
7d5889b
to
f8df549
Compare
|
Great, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!