Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queryservice: remove transitional allowlist values #1821

Merged
merged 1 commit into from
Oct 29, 2024
Merged

queryservice: remove transitional allowlist values #1821

merged 1 commit into from
Oct 29, 2024

Conversation

AndrewKostka
Copy link
Contributor

Bug: T375384

tarrow
tarrow approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is find but we'll need to make sure that the configmap is repopulated (by running the api job) right after deploying because I believe merging this patch will blank the configmap

@AndrewKostka AndrewKostka merged commit 63a3fb7 into main Oct 29, 2024
4 checks passed
@AndrewKostka AndrewKostka deleted the queryservice-allowlist-api branch October 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewKostka @tarrow