Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scorecard values for total item and properties from 50th percentile to Mean #1764

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

rosalieper
Copy link
Contributor

@rosalieper rosalieper commented Aug 28, 2024

Describe the changes

	1. On the Platform Summary dashboard in Google Cloud the scorecards total items and total properties
	are configured to 50th percentile instead of Mean and therefore show incorrect numbers not matching the charts ?
	2. I made the change on the google cloud dashboard and downloaded the json with
	which I then updated these files?

This is what I need help with

Please confirm this has no bomb in it and can be deployed to production.

Link to Phabricator

https://phabricator.wikimedia.org/T369347

@AndrewKostka
Copy link
Contributor

It might be easier if we only replace REDUCE_PERCENTILE_50 with REDUCE_MEAN in the JSON for the two relevant scorecards. I've noticed issues with subsequent Terraform runs always trying to re-apply any default values.

@rosalieper rosalieper force-pushed the scorecard-correction branch 2 times, most recently from e2f9be6 to c83bf65 Compare August 29, 2024 10:20
@rosalieper rosalieper merged commit 7c25abe into main Sep 3, 2024
3 checks passed
@rosalieper rosalieper deleted the scorecard-correction branch September 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants