refactor: argo password reset script #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
reviewed
Jul 3, 2024
bin/reset-argocd-password
Outdated
| --type='json' \ | ||
| --patch="[{'op': 'replace', 'path': '/data/admin.password', 'value': '${ENCODED_HASH}'}]" | ||
| } | ||
|
|
||
| PASSWORD=$(pwgen -N1 -Bs 32) |
There was a problem hiding this comment.
Unrelated to this change, but is pwgen a commonly installed tool? I've never heard of it yet, and it's not installed on my system. Maybe we can get away with reading from urandom which should work kind of everywhere
tr -dc A-Za-z0-9 </dev/urandom | head -c 32
Feel free to disregard this.
There was a problem hiding this comment.
I think it's fairly common but I still like your suggestion, thanks 🎇
m90
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some improvements to the password reset script, so that per default its only output is the new password.