Improve ESLint configuration #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new "flat" configuration style, copied over from the fundraising application. Use the newly-converted "wikimedia" rules for formatting and typescript. Fix all files where ESLint had a legitimate complaint, applying rules that were not there before and that are not auto-fixable or just formatting issues.
Closed
Copied the rules from the [mediawiki coding style](https://github.com/wikimedia/eslint-config-wikimedia) Marked & commented out rules that will change the code significantly, those will need a discussion & decision with the whole team. Commented out some rules that'll be part of the commit that automatically fixes violations. Fixed/changed some components that had violations. The components in DonationForm/Forms all have an `isCurrent` property that's no longer used in the markup. I decided to ignore the notification for now, because the banners component still pass `is-current` to the forms and the property could be useful in the future.
The formatting rules are purely stylistic and add more spaces in Vue components. Auto-Fix components
Activate auto-fixable ESLint rules and fix code style
Remove eslint-config-wikimedia - we have implemented its rules in the ESLint 9 "flat" configuration ourselves Remove eslint-plugin-jsdoc and eslint-plugin-yml - we're not using them and they were probably an attempt to fix a eslint-config-wikimedia dependency Add types to MultiStepDonation form component to make the update TypeScript compiler happy
moiikana
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new "flat" configuration style, copied over from the fundraising application.
Use the newly-converted "wikimedia" rules for formatting and typescript.
Apply fixes