C24_WMDE_Mobile_DE_10 #636
Open
+2,253
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
2 times, most recently
from
8a52cfa
to
27ab26d
Compare
moiikana
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
5 times, most recently
from
9cedf88
to
df84a45
Compare
gbirke
reviewed
Nov 22, 2024
- got missing during some recent fixes
- both banners should have different amount options in the fullpage banner, depending on what button was clicked on the mini banner https://phabricator.wikimedia.org/T380461
moiikana
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
5 times, most recently
from
57264aa
to
53b5605
Compare
- var has custom formActions
When submitting the banner form with an amount below €10, users are redirected to a donation form variant.
When submitting the banner form with an amount above or equal to €10, users are redirected to the default donation form.
When submitting the banner form with any amount using direct-debit, users are redirected to the default donation form.
- add tests for "changesAmountOption" feature
- make euro symbol white when value got entered in select group
https://phabricator.wikimedia.org/T380461
moiikana
force-pushed
the
C24_WMDE_Mobile_DE_10
branch
from
53b5605
to
5d5a0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on mobde09
If the "Anderer Betrag" button is clicked in the mini banner, the amount option of €10 is changed to €5.
var:
When submitting the banner form with an amount below €10, users are redirected to a donation form variant.
When submitting the banner form with an amount above €10, users are redirected to the default donation form.
When submitting the banner form with any amount using direct-debit, users are redirected to the default donation form.
tests added + fixed
https://phabricator.wikimedia.org/T380461