Disable "no" option for direct debit #539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
disable-anonymous-ap1-option
branch
from
42d3c88
to
80e28a1
Compare
- we demand a full address from users when they select direct debit as a payment option. when asking about if they want to have a receipt, they need to say yes (give address), so we have to disable the "no" option. - respectively the DirectDebit option should be disabled when "no" got selected first - lift the tooltip message above other neighboring elements that updated dynamically this fixes https://phabricator.wikimedia.org/T379565
moiikana
force-pushed
the
disable-anonymous-ap1-option
branch
from
80e28a1
to
6a1c249
Compare
Abban
approved these changes
Nov 13, 2024
| @@ -121,4 +132,14 @@ useAddressTypeFromReceiptSetter( props.receiptModel.receiptNeeded, toRef( props. | |||
|
|
|||
| onBeforeMount( initializeDataFromStore ); | |||
|
|
|||
| const disabledReceiptNeededOptions = computed<string[]>( () => { | |||
There was a problem hiding this comment.
This is typed as a string[] but the map is returning a boolean[] which I guess is why you cast the CheckboxFormOption to Object. You can simplify this logic by changing it to:
const disabledReceiptNeededOptions = computed<boolean[]>( () => {
return props.isDirectDebitPayment ? [ false ] : [];
} );You can also then move the options back into the template.
|
should allow an implicit "email only" type on the ap=1 form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we demand a full address from users when they select direct debit as a payment option. when asking about if they want to have a receipt, they need to say yes (give address), so we have to disable the "no" option.
respectively the DirectDebit option should be disabled when "no" got selected first
lift the tooltip message above other neighboring elements that updated dynamically
this fixes https://phabricator.wikimedia.org/T379565