Change first donation form section summary behaviour #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sperling-0
force-pushed
the
donation-summary
branch
from
a93c18d
to
5678ab9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sperling-0
force-pushed
the
donation-summary
branch
from
5678ab9
to
320f06e
Compare
Sperling-0
force-pushed
the
donation-summary
branch
from
1d0c953
to
7d699ab
Compare
gbirke
requested changes
Sep 17, 2024
There was a problem hiding this comment.
This component is untested. Previously that was not a big issue because is was just rendering stuff and we usually don't test these kinds of components. Now it contains logic/branching and that should be tested. Could you add a unit test that checks both cases? The test should check rendering with and without payment time, checking for the existence of amount, interval and (option) payment type in the rendered output. You can go the easy route and use snapshots, see the first tests in SubmitValues.spec.ts. If you manually control the output of the snapshot file and check it in, that'll be sufficient.
- When there is no payment type passed to the donation form, the summary only shows the data that is already there - When selecting a payment type, the summary reflects that - Add tests Ticket: https://phabricator.wikimedia.org/T368527
Sperling-0
force-pushed
the
donation-summary
branch
from
7d699ab
to
6eb8bb6
Compare
gbirke
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://phabricator.wikimedia.org/T368527