Add street autocomplete to alternate address form #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
street-autocomplete-new-address
branch
from
a62d286
to
489a765
Compare
|
( ℹ️ for reviewers: supposed to be tested with ap=1&afo=1 I think) |
gbirke
approved these changes
Sep 9, 2024
Abban
force-pushed
the
street-autocomplete-new-address
branch
4 times, most recently
from
dfbdc8a
to
b10c277
Compare
We're about to do a test that needs both features so now both address forms have both form orders. The bank validation error in the summary wasn't appearing so I modified the summary components to watch the store through a computed value. Some of the error summaries contained the wrong focus and scroll ids for the direct debit field. This should now be fixed. The summary was vanishing if the bankdata was invalid and the rest of the form was valid, so I updated the useAddressFormEventHandlers composable to mark it as invalid properly and added a test. I also noticed that the error summaries weren't displaying all the errors on the alternate form when the donor had selected yes for receipt and not selected an address type. Ticket: https://phabricator.wikimedia.org/T374216
Abban
force-pushed
the
street-autocomplete-new-address
branch
from
b10c277
to
a88f01f
Compare
gbirke
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're about to do a test that needs both features
so now both address forms have both form orders
I also noticed that the error summaries weren't displaying
all the errors on the alternate form when the donor had
selected yes for receipt and not selected an address type.
Ticket: https://phabricator.wikimedia.org/T374216