Fix error logging #193
Merged
Fix error logging #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the upgrade to Webpack 5, we accidentally broke the logger factory because the `process.env.VUE_APP_LOGGER` was no longer defined. We now define it in the webpack environment configuration files. Additionally, we only override the error logger in production, to send errors to our error logging tool.
Abban
reviewed
Sep 20, 2023
We currently don't use it and can save a few bytes by removing it.
Abban
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to Webpack 5, we accidentally broke the logger factory
because the
process.env.VUE_APP_LOGGERwas no longer defined. We nowdefine it in the webpack environment configuration files.
Additionally, we only override the error logger in production, to send
errors to our error logging tool.