-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new namespace strategy #2523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
idoros
reviewed
May 20, 2022
This was referenced May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new universal namespace strategy
Features:
This strategy should support our existing node, no collision and default strategy
Should close:
st-namespace-reference
to be present #2286Should handle:
TODO:
Notes:
This strategy should not treated as breaking change unless someone was depending on the current hash (murmur) output.
We still need to check if we don't use
namespace\d+
regexp in out solutions like: